From fc59b515587a549413e72f919ba31d3687586640 Mon Sep 17 00:00:00 2001 From: andsel Date: Fri, 27 Apr 2018 13:08:12 +0200 Subject: [PATCH] Fix #381, avoid t print password on bad signin during connect --- .../main/java/io/moquette/spi/impl/ProtocolProcessor.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/broker/src/main/java/io/moquette/spi/impl/ProtocolProcessor.java b/broker/src/main/java/io/moquette/spi/impl/ProtocolProcessor.java index 035ea017..4088ccd3 100644 --- a/broker/src/main/java/io/moquette/spi/impl/ProtocolProcessor.java +++ b/broker/src/main/java/io/moquette/spi/impl/ProtocolProcessor.java @@ -297,13 +297,13 @@ public class ProtocolProcessor { failedCredentials(channel); return false; } - if (!m_authenticator.checkValid(clientId, msg.payload().userName(), pwd)) { - LOG.error("Authenticator has rejected the MQTT credentials CId={}, username={}, password={}", - clientId, msg.payload().userName(), pwd); + final String login = msg.payload().userName(); + if (!m_authenticator.checkValid(clientId, login, pwd)) { + LOG.error("Authenticator has rejected the MQTT credentials CId={}, username={}", clientId, login); failedCredentials(channel); return false; } - NettyUtils.userName(channel, msg.payload().userName()); + NettyUtils.userName(channel, login); } else if (!this.allowAnonymous) { LOG.error("Client didn't supply any credentials and MQTT anonymous mode is disabled. CId={}", clientId); failedCredentials(channel);