From f18ba2e2480bf6c8d0c0f17e6bb8ab56b20b2095 Mon Sep 17 00:00:00 2001 From: andsel Date: Fri, 3 Aug 2012 15:44:11 +0200 Subject: [PATCH] Fixed potential indefinite lock retention --- .../dna/mqtt/moquette/messaging/spi/impl/SimpleMessaging.java | 1 + 1 file changed, 1 insertion(+) diff --git a/parser/src/main/java/org/dna/mqtt/moquette/messaging/spi/impl/SimpleMessaging.java b/parser/src/main/java/org/dna/mqtt/moquette/messaging/spi/impl/SimpleMessaging.java index b6e78d60..684d5b73 100644 --- a/parser/src/main/java/org/dna/mqtt/moquette/messaging/spi/impl/SimpleMessaging.java +++ b/parser/src/main/java/org/dna/mqtt/moquette/messaging/spi/impl/SimpleMessaging.java @@ -45,6 +45,7 @@ public class SimpleMessaging implements IMessaging { Subscription newSubscription = new Subscription(clientId, topic, qos); rwLock.writeLock().lock(); if (subscriptions.contains(newSubscription)) { + rwLock.writeLock().unlock(); return; } subscriptions.add(newSubscription);