Refactored common setup code in a setup method

This commit is contained in:
selva.andre
2012-01-22 18:25:55 +01:00
parent 463aa25693
commit ee76a1c360
@@ -6,6 +6,7 @@ import org.apache.mina.core.filterchain.IoFilterAdapter;
import org.apache.mina.core.session.DummySession; import org.apache.mina.core.session.DummySession;
import org.apache.mina.core.session.IoSession; import org.apache.mina.core.session.IoSession;
import org.dna.mqtt.moquette.proto.messages.ConnectMessage; import org.dna.mqtt.moquette.proto.messages.ConnectMessage;
import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import static org.junit.Assert.*; import static org.junit.Assert.*;
@@ -15,29 +16,39 @@ import static org.junit.Assert.*;
*/ */
public class MQTTHandlerTest { public class MQTTHandlerTest {
@Test byte m_returnCode;
public void testHandleConnect_BadProtocol() {
MQTTHandler h = new MQTTHandler(); IoSession m_session;
ConnectMessage connMsg = new ConnectMessage();
connMsg.setProcotolVersion((byte) 0x02); @Before
public void setUp() {
IoSession session = new DummySession(); m_session = new DummySession();
session.getFilterChain().addFirst("MessageCatcher", new IoFilterAdapter() { m_session.getFilterChain().addFirst("MessageCatcher", new IoFilterAdapter() {
@Override @Override
public void filterWrite(NextFilter nextFilter, IoSession session, public void filterWrite(NextFilter nextFilter, IoSession session,
WriteRequest writeRequest) throws Exception { WriteRequest writeRequest) throws Exception {
try { try {
ConnAckMessage buf = (ConnAckMessage) writeRequest.getMessage(); ConnAckMessage buf = (ConnAckMessage) writeRequest.getMessage();
assertEquals(ConnAckMessage.UNNACEPTABLE_PROTOCOL_VERSION, buf.getReturnCode()); m_returnCode = buf.getReturnCode();
} catch (Exception ex) { } catch (Exception ex) {
fail("Wrong return code"); throw new AssertionError("Wrong return code");
} }
} }
}); });
}
@Test
public void testHandleConnect_BadProtocol() {
MQTTHandler h = new MQTTHandler();
ConnectMessage connMsg = new ConnectMessage();
connMsg.setProcotolVersion((byte) 0x02);
//Exercise //Exercise
h.handleConnect(session, connMsg); h.handleConnect(m_session, connMsg);
//Verify
assertEquals(ConnAckMessage.UNNACEPTABLE_PROTOCOL_VERSION, m_returnCode);
} }
@@ -48,25 +59,10 @@ public class MQTTHandlerTest {
connMsg.setProcotolVersion((byte) 0x03); connMsg.setProcotolVersion((byte) 0x03);
connMsg.setClientID("extremely_long_clientID_grtaer_than_23"); connMsg.setClientID("extremely_long_clientID_grtaer_than_23");
IoSession session = new DummySession();
session.getFilterChain().addFirst("MessageCatcher", new IoFilterAdapter() {
@Override
public void filterWrite(NextFilter nextFilter, IoSession session,
WriteRequest writeRequest) throws Exception {
try {
ConnAckMessage buf = (ConnAckMessage) writeRequest.getMessage();
assertEquals(ConnAckMessage.IDENTIFIER_REJECTED, buf.getReturnCode());
} catch (Exception ex) {
fail("Wrong return code");
}
}
});
//Exercise //Exercise
h.handleConnect(session, connMsg); h.handleConnect(m_session, connMsg);
//Verify
assertEquals(ConnAckMessage.IDENTIFIER_REJECTED, m_returnCode);
} }
} }