重构
This commit is contained in:
@@ -51,9 +51,7 @@ public class AddGroupMemberAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -60,9 +60,7 @@ public class CreateGroupAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -32,9 +32,7 @@ public class DeleteCallbackAction extends RobotAction {
|
||||
robot = robot.toBuilder().clearCallback().setState(0).build();
|
||||
messagesStore.addRobot(robot);
|
||||
}
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.ok();
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.ok());
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -51,9 +51,7 @@ public class DismissGroupAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -33,9 +33,7 @@ public class GetCallbackAction extends RobotAction {
|
||||
if (request.getNettyRequest() instanceof FullHttpRequest) {
|
||||
RobotCallbackPojo out = new RobotCallbackPojo();
|
||||
out.setUrl(robot.getCallback());
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.ok(out);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.ok(out));
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -41,8 +41,6 @@ public class GetGroupInfoAction extends RobotAction {
|
||||
&& (!StringUtil.isNullOrEmpty(inputGetGroup.getGroupId()))) {
|
||||
|
||||
WFCMessage.GroupInfo groupInfo = messagesStore.getGroupInfo(inputGetGroup.getGroupId());
|
||||
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result;
|
||||
if (groupInfo == null) {
|
||||
result = RestResult.resultOf(ErrorCode.ERROR_CODE_NOT_EXIST);
|
||||
@@ -56,12 +54,9 @@ public class GetGroupInfoAction extends RobotAction {
|
||||
pojoGroupInfo.setType(groupInfo.getType());
|
||||
result = RestResult.ok(pojoGroupInfo);
|
||||
}
|
||||
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(result);
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -48,9 +48,6 @@ public class GetGroupMembersAction extends RobotAction {
|
||||
|
||||
List<WFCMessage.GroupMember> members = new ArrayList<>();
|
||||
ErrorCode errorCode = messagesStore.getGroupMembers(null, inputGetGroup.getGroupId(), 0, members);
|
||||
|
||||
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result;
|
||||
if (errorCode != ErrorCode.ERROR_CODE_SUCCESS) {
|
||||
result = RestResult.resultOf(errorCode);
|
||||
@@ -77,11 +74,9 @@ public class GetGroupMembersAction extends RobotAction {
|
||||
result = RestResult.ok(out);
|
||||
}
|
||||
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(result);
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -43,19 +43,15 @@ public class GetUserAction extends RobotAction {
|
||||
user = messagesStore.getUserInfoByMobile(inputUserId.getMobile());
|
||||
}
|
||||
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result;
|
||||
if (user == null) {
|
||||
result = RestResult.resultOf(ErrorCode.ERROR_CODE_NOT_EXIST);
|
||||
} else {
|
||||
result = RestResult.ok(InputOutputUserInfo.fromPbUser(user));
|
||||
}
|
||||
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(result);
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
+1
-3
@@ -51,9 +51,7 @@ public class KickoffGroupMemberAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -51,9 +51,7 @@ public class ModifyGroupInfoAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
+1
-3
@@ -51,9 +51,7 @@ public class ModifyGroupMemberAliasAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -51,9 +51,7 @@ public class QuitGroupMemberAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -54,9 +54,7 @@ public class SendMessageAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -35,14 +35,9 @@ public class SetCallbackAction extends RobotAction {
|
||||
robot = robot.toBuilder().setCallback(input.getUrl()).setState(1).build();
|
||||
messagesStore.addRobot(robot);
|
||||
}
|
||||
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.ok();
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.ok());
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -51,9 +51,7 @@ public class TransferGroupAction extends RobotAction {
|
||||
});
|
||||
return false;
|
||||
} else {
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.resultOf(ErrorCode.INVALID_PARAMETER);
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(RestResult.resultOf(ErrorCode.INVALID_PARAMETER));
|
||||
}
|
||||
}
|
||||
return true;
|
||||
|
||||
@@ -76,7 +76,6 @@ public class UpdateProfileAction extends RobotAction {
|
||||
break;
|
||||
}
|
||||
|
||||
response.setStatus(HttpResponseStatus.OK);
|
||||
RestResult result = RestResult.ok();
|
||||
if(modified) {
|
||||
try {
|
||||
@@ -86,8 +85,7 @@ public class UpdateProfileAction extends RobotAction {
|
||||
result.setErrorCode(ErrorCode.ERROR_CODE_SERVER_ERROR);
|
||||
}
|
||||
}
|
||||
|
||||
response.setContent(new Gson().toJson(result));
|
||||
setResponseContent(result);
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user