diff --git a/broker/src/main/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollector.java b/broker/src/main/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollector.java index 269ce465..90d0ce1f 100644 --- a/broker/src/main/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollector.java +++ b/broker/src/main/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollector.java @@ -48,12 +48,8 @@ class AuthorizationsCollector implements IAuthorizator { return coll; } - void parse(String line) { - try { - m_authorizations.add(parseAuthLine(line)); - } catch (ParseException pex) { - LOG.warn(String.format("Error parsing ACL definition [%s]", line), pex); - } + void parse(String line) throws ParseException { + m_authorizations.add(parseAuthLine(line)); } protected static Authorization parseAuthLine(String line) throws ParseException { diff --git a/broker/src/test/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollectorTest.java b/broker/src/test/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollectorTest.java index de6f8325..5020e0d1 100644 --- a/broker/src/test/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollectorTest.java +++ b/broker/src/test/java/org/eclipse/moquette/spi/impl/security/AuthorizationsCollectorTest.java @@ -20,9 +20,6 @@ import org.junit.Test; import java.text.ParseException; -import static java.util.Arrays.asList; -import static org.eclipse.moquette.spi.impl.security.Authorization.Permission.READ; -import static org.eclipse.moquette.spi.impl.security.Authorization.Permission.WRITE; import static org.eclipse.moquette.spi.impl.security.AuthorizationsCollector.*; import static org.junit.Assert.*; @@ -90,7 +87,7 @@ public class AuthorizationsCollectorTest { } @Test - public void testCanWriteSimpleTopic() { + public void testCanWriteSimpleTopic() throws ParseException { authorizator.parse("topic write /sensors"); //verify @@ -98,7 +95,7 @@ public class AuthorizationsCollectorTest { } @Test - public void testCanReadSimpleTopic() { + public void testCanReadSimpleTopic() throws ParseException { authorizator.parse("topic read /sensors"); //verify @@ -106,7 +103,7 @@ public class AuthorizationsCollectorTest { } @Test - public void testCanReadWriteMixedSimpleTopic() { + public void testCanReadWriteMixedSimpleTopic() throws ParseException { authorizator.parse("topic write /sensors"); authorizator.parse("topic read /sensors/anemometer"); @@ -116,7 +113,7 @@ public class AuthorizationsCollectorTest { } @Test - public void testCanWriteMultiMatherTopic() { + public void testCanWriteMultiMatherTopic() throws ParseException { authorizator.parse("topic write /sensors/#"); //verify @@ -124,7 +121,7 @@ public class AuthorizationsCollectorTest { } @Test - public void testCanWriteSingleMatherTopic() { + public void testCanWriteSingleMatherTopic() throws ParseException { authorizator.parse("topic write /sensors/+"); //verify