From 90998c447bee434a740ff2c5ebdaca06852d9c3e Mon Sep 17 00:00:00 2001 From: teranisi Date: Thu, 20 Oct 2016 14:17:27 +0900 Subject: [PATCH] Make Subscription class immutable. --- .../moquette/spi/impl/subscriptions/Subscription.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/broker/src/main/java/io/moquette/spi/impl/subscriptions/Subscription.java b/broker/src/main/java/io/moquette/spi/impl/subscriptions/Subscription.java index cca2b1af..1b087769 100644 --- a/broker/src/main/java/io/moquette/spi/impl/subscriptions/Subscription.java +++ b/broker/src/main/java/io/moquette/spi/impl/subscriptions/Subscription.java @@ -26,17 +26,18 @@ import io.moquette.spi.ISessionsStore.ClientTopicCouple; * * @author andrea */ -public class Subscription implements Serializable { +public final class Subscription implements Serializable { - QOSType requestedQos; //max QoS acceptable - String clientId; - String topicFilter; - boolean active = true; + final QOSType requestedQos; //max QoS acceptable + final String clientId; + final String topicFilter; + final boolean active; public Subscription(String clientId, String topicFilter, QOSType requestedQos) { this.requestedQos = requestedQos; this.clientId = clientId; this.topicFilter = topicFilter; + this.active = true; } public Subscription(Subscription orig) {