Remove unused imports, raw types and some deprecated method calls..

broker/src/main/java/io/moquette/spi/IMessagesStore.java

@@ -20,8 +20,6 @@ import java.nio.ByteBuffer;
 import io.moquette.parser.proto.messages.AbstractMessage;
 
 import java.util.Collection;
-import java.util.List;
-import java.util.concurrent.atomic.AtomicInteger;
 
 /**
  * Defines the SPI to be implemented by a StorageService that handle persistence of messages
@@ -29,7 +27,8 @@ import java.util.concurrent.atomic.AtomicInteger;
 public interface IMessagesStore {
 
     class StoredMessage implements Serializable {
-        final AbstractMessage.QOSType m_qos;
+		private static final long serialVersionUID = 1L;
+		final AbstractMessage.QOSType m_qos;
         final byte[] m_payload;
         final String m_topic;
         private boolean m_retained;

broker/src/main/java/io/moquette/spi/MessageGUID.java

@@ -21,7 +21,8 @@ import java.io.Serializable;
  * Value object for GUIDs of messages.
  * */
 public class MessageGUID implements Serializable {
-    private final String guid;
+	private static final long serialVersionUID = 1L;
+	private final String guid;
 
     public MessageGUID(String guid) {
         this.guid = guid;

broker/src/main/java/io/moquette/spi/impl/InternalRepublisher.java

@@ -12,7 +12,6 @@ import java.nio.ByteBuffer;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
-import java.util.Queue;
 import java.util.concurrent.BlockingQueue;
 
 class InternalRepublisher {

broker/src/main/java/io/moquette/spi/impl/ProtocolProcessorBootstrapper.java

@@ -106,7 +106,6 @@ public class ProtocolProcessorBootstrapper {
 
         subscriptions.init(m_sessionsStore);
 
-        String configPath = System.getProperty("moquette.path", null);
         String authenticatorClassName = props.getProperty(BrokerConstants.AUTHENTICATOR_CLASS_NAME, "");
 
         if (!authenticatorClassName.isEmpty()) {

broker/src/main/java/io/moquette/spi/impl/security/DBAuthenticator.java

@@ -22,7 +22,6 @@ public class DBAuthenticator implements IAuthenticator {
 
     private static final Logger LOG = LoggerFactory.getLogger(DBAuthenticator.class);
 
-    private final String sqlQuery;
     private final MessageDigest messageDigest;
     private final PreparedStatement preparedStatement;
 
@@ -44,7 +43,6 @@ public class DBAuthenticator implements IAuthenticator {
      */
     public DBAuthenticator(String driver, String jdbcUrl, String sqlQuery, String digestMethod){
 
-        this.sqlQuery = sqlQuery;
         try {
             Class.forName(driver);
             final Connection connection = DriverManager.getConnection(jdbcUrl);

broker/src/main/java/io/moquette/spi/impl/security/ResourceAuthenticator.java

@@ -17,7 +17,6 @@ package io.moquette.spi.impl.security;
 
 import io.moquette.server.config.IResourceLoader;
 import io.moquette.spi.security.IAuthenticator;
-import org.apache.commons.codec.binary.Hex;
 import org.apache.commons.codec.digest.DigestUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

broker/src/main/java/io/moquette/spi/impl/subscriptions/Subscription.java

@@ -28,7 +28,8 @@ import io.moquette.spi.ISessionsStore.ClientTopicCouple;
  */
 public final class Subscription implements Serializable {
     
-    final QOSType requestedQos; //max QoS acceptable
+	private static final long serialVersionUID = 1L;
+	final QOSType requestedQos; //max QoS acceptable
     final String clientId;
     final String topicFilter;
     final boolean active;

broker/src/main/java/io/moquette/spi/persistence/MapDBPersistentStore.java

@@ -45,7 +45,8 @@ public class MapDBPersistentStore {
      * a session.
      * */
     public static class PersistentSession implements Serializable {
-        public final boolean cleanSession;
+		private static final long serialVersionUID = 1L;
+		public final boolean cleanSession;
 
         public PersistentSession(boolean cleanSession) {
             this.cleanSession = cleanSession;

broker/src/main/java/io/moquette/spi/persistence/MapDBSessionsStore.java

@@ -16,7 +16,6 @@
 package io.moquette.spi.persistence;
 
 import io.moquette.spi.ClientSession;
-import io.moquette.spi.IMessagesStore;
 import io.moquette.spi.IMessagesStore.StoredMessage;
 import io.moquette.spi.ISessionsStore;
 import io.moquette.spi.MessageGUID;