anna/IM-server-new
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Terminating the connection if the client failed to receive a CONNACK packet with a non-zero return code. Stated in 3.2.2.3 of MQTT 3.1.1 specificaton.

Browse Source 
Was checking the wrong channel to see if it was still open or not. The channel that the test was checking on was disconnected a few lines above.
This commit is contained in:
Kevin Berendsen
2016-08-07 13:34:06 +02:00
parent 32b6b9b1da
commit 807debb622
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
broker/src/test/java/io/moquette/spi/impl/ProtocolProcessor_CONNECT_Test.java
+11
View File
@@ -95,6 +95,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(UNNACEPTABLE_PROTOCOL_VERSION, m_session.readOutbound());
assertFalse("Connection should be closed by the broker.", m_session.isOpen());
}
@Test
@@ -122,6 +123,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(CONNECTION_ACCEPTED, m_session.readOutbound());
assertTrue("Connection is accepted and therefore should remain open.", m_session.isOpen());
//TODO verify the call
/*verify(mockedMessaging).publish(eq("topic"), eq("Topic message".getBytes()),
any(AbstractMessage.QOSType.class), anyBoolean(), eq("123"), any(IoSession.class));*/
@@ -140,6 +142,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(CONNECTION_ACCEPTED, m_session.readOutbound());
assertTrue("Connection is accepted and therefore should remain open.", m_session.isOpen());
}
@Test
@@ -154,6 +157,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(BAD_USERNAME_OR_PASSWORD, m_session.readOutbound());
assertFalse("Connection should be closed by the broker.", m_session.isOpen());
}
@Test
@@ -169,6 +173,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(BAD_USERNAME_OR_PASSWORD, m_session.readOutbound());
assertFalse("Connection should be closed by the broker.", m_session.isOpen());
}
@Test
@@ -182,6 +187,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(BAD_USERNAME_OR_PASSWORD, m_session.readOutbound());
assertFalse("Connection should be closed by the broker.", m_session.isOpen());
}
@Test
@@ -197,6 +203,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(BAD_USERNAME_OR_PASSWORD, m_session.readOutbound());
assertFalse("Connection should be closed by the broker.", m_session.isOpen());
}
@Test
@@ -210,6 +217,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(CONNECTION_ACCEPTED, m_session.readOutbound());
assertTrue("Connection is accepted and therefore should remain open.", m_session.isOpen());
}
@Test
@@ -294,6 +302,7 @@ public class ProtocolProcessor_CONNECT_Test {
//Verify
assertEqualsConnAck(CONNECTION_ACCEPTED, firstReceiverSession.readOutbound());
assertTrue("Connection is accepted and therefore should remain open.", firstReceiverSession.isOpen());
}
@@ -306,6 +315,7 @@ public class ProtocolProcessor_CONNECT_Test {
connMsg.setCleanSession(false);
m_processor.processConnect(m_session, connMsg);
assertEqualsConnAck(CONNECTION_ACCEPTED, m_session.readOutbound());
assertTrue("Connection is accepted and therefore should remain open.", m_session.isOpen());
//subscribe
SubscribeMessage subscribeMsg = new SubscribeMessage();
@@ -327,6 +337,7 @@ public class ProtocolProcessor_CONNECT_Test {
m_session = new EmbeddedChannel();
m_processor.processConnect(m_session, connMsg);
assertEqualsConnAck(CONNECTION_ACCEPTED, m_session.readOutbound());
assertTrue("Connection is accepted and therefore should remain open.", m_session.isOpen());
//verify that the first subscription is still preserved
assertTrue(subscriptions.contains(expectedSubscription));