From 3ebb9c7d48f3f72cb94f171e24aff8cba48d6e05 Mon Sep 17 00:00:00 2001 From: Andreas Mager Date: Wed, 1 Feb 2017 16:23:20 +0100 Subject: [PATCH] broker/ConnectionIT: code formatter used --- .../spec/v3_1_1/connection/ConnectionIT.java | 158 +++++++++--------- 1 file changed, 81 insertions(+), 77 deletions(-) diff --git a/broker/src/test/java/io/moquette/spec/v3_1_1/connection/ConnectionIT.java b/broker/src/test/java/io/moquette/spec/v3_1_1/connection/ConnectionIT.java index 301b06ec..a81b32d0 100644 --- a/broker/src/test/java/io/moquette/spec/v3_1_1/connection/ConnectionIT.java +++ b/broker/src/test/java/io/moquette/spec/v3_1_1/connection/ConnectionIT.java @@ -13,14 +13,13 @@ * * You may elect to redistribute this code under either of these licenses. */ + package io.moquette.spec.v3_1_1.connection; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; - import java.io.File; import java.io.IOException; - import io.moquette.BrokerConstants; import io.moquette.server.Server; import io.moquette.testclient.RawClient; @@ -32,12 +31,12 @@ import org.junit.Test; /** * * @author pkhanal - * + * */ public class ConnectionIT { - - Server m_server; - + + Server m_server; + protected void startServer() throws IOException { m_server = new Server(); m_server.startServer(); @@ -54,7 +53,9 @@ public class ConnectionIT { File dbFile = new File(BrokerConstants.DEFAULT_PERSISTENT_PATH); if (dbFile.exists()) { - assertTrue("Error deleting the moquette db file " + BrokerConstants.DEFAULT_PERSISTENT_PATH, dbFile.delete()); + assertTrue( + "Error deleting the moquette db file " + BrokerConstants.DEFAULT_PERSISTENT_PATH, + dbFile.delete()); } assertFalse(dbFile.exists()); } @@ -62,100 +63,103 @@ public class ConnectionIT { @Test(timeout = 3000) public void testConnectThenClose() throws Exception { RawClient.connect("127.0.0.1", 1883).isConnected() - //CONNECT - .write(0x10) //MQTT Control Packet type(1) - .write(0x13) // Remaining Length - .write(0x00, 0x04) // Protocol Name Length - .write("MQTT") // Protocol Name - .write(0x04) // The value of the Protocol Level field for the version 3.1.1 of the protocol is 4 (0x04) + // CONNECT + .write(0x10) // MQTT Control Packet type(1) + .write(0x13) // Remaining Length + .write(0x00, 0x04) // Protocol Name Length + .write("MQTT") // Protocol Name + .write(0x04) // The value of the Protocol Level field for the version 3.1.1 of the + // protocol is 4 (0x04) - //Connect Flags - //User Name Flag(0) - //Password Flag(0) - //Will Retain(0) - //Will QoS(00) - //Will Flag(0) - //Clean Session(1) - .write(0x02) // Reserved(0) - .write(0x00, 0x00) // Keep Alive + // Connect Flags + // User Name Flag(0) + // Password Flag(0) + // Will Retain(0) + // Will QoS(00) + // Will Flag(0) + // Clean Session(1) + .write(0x02) // Reserved(0) + .write(0x00, 0x00) // Keep Alive - // Payload - .write(0x00, 0x07) // Client Identifier Length - .write("client1") // Client Identifier - .flush() + // Payload + .write(0x00, 0x07) // Client Identifier Length + .write("client1") // Client Identifier + .flush() - //CONNACK - .read(0x20) // MQTT Control Packet type(2) - .read(0x02) // Remaining Length + // CONNACK + .read(0x20) // MQTT Control Packet type(2) + .read(0x02) // Remaining Length - //Connect Acknowledge Flags - .read(0x00) // Session Present Flag(0) + // Connect Acknowledge Flags + .read(0x00) // Session Present Flag(0) - //Connect Return code - .read(0x00) // Connection Accepted + // Connect Return code + .read(0x00) // Connection Accepted - //DISCONNECT - .write(0xE0) // MQTT Control Packet type(14) - .write(0x00) // Remaining Length - .closed(1000); + // DISCONNECT + .write(0xE0) // MQTT Control Packet type(14) + .write(0x00) // Remaining Length + .closed(1000); } @Test(timeout = 3000) public void testConnectWithInvalidWillQoS() throws Exception { RawClient.connect("127.0.0.1", 1883).isConnected() - //CONNECT - .write(0x10) //MQTT Control Packet type(1) - .write(0x13) // Remaining Length - .write(0x00, 0x04) // Protocol Name Length - .write("MQTT") // Protocol Name - .write(0x04) // The value of the Protocol Level field for the version 3.1.1 of the protocol is 4 (0x04) + // CONNECT + .write(0x10) // MQTT Control Packet type(1) + .write(0x13) // Remaining Length + .write(0x00, 0x04) // Protocol Name Length + .write("MQTT") // Protocol Name + .write(0x04) // The value of the Protocol Level field for the version 3.1.1 of the + // protocol is 4 (0x04) - //Connect Flags - //User Name Flag(0) - //Password Flag(0) - //Will Retain(0) - //Will QoS(11) - It MUST NOT be 3 (0x03). Server should close the connection. - //Will Flag(1) - //Clean Session(1) - .write(0x1E) // Reserved(0) - .write(0x00, 0x00) // Keep Alive + // Connect Flags + // User Name Flag(0) + // Password Flag(0) + // Will Retain(0) + // Will QoS(11) - It MUST NOT be 3 (0x03). Server should close the connection. + // Will Flag(1) + // Clean Session(1) + .write(0x1E) // Reserved(0) + .write(0x00, 0x00) // Keep Alive - // Payload - .write(0x00, 0x07) // Client Identifier Length - .write("client1") // Client Identifier - .flush() + // Payload + .write(0x00, 0x07) // Client Identifier Length + .write("client1") // Client Identifier + .flush() - .closed(1000); + .closed(1000); } @Ignore("Need to validate the test case.") @Test(timeout = 15000) public void testConnectWithWillFlagSetToZeroButWillQoSFlagSetToNonZero() throws Exception { RawClient.connect("127.0.0.1", 1883).isConnected() - // CONNECT - .write(0x10) // MQTT Control Packet type(1) - .write(0x12) // Remaining Length - .write(0x00, 0x04) // Protocol Name Length - .write("MQTT") // Protocol Name - .write(0x04) // The value of the Protocol Level field for the version 3.1.1 of the protocol is 4 (0x04) + // CONNECT + .write(0x10) // MQTT Control Packet type(1) + .write(0x12) // Remaining Length + .write(0x00, 0x04) // Protocol Name Length + .write("MQTT") // Protocol Name + .write(0x04) // The value of the Protocol Level field for the version 3.1.1 of the + // protocol is 4 (0x04) - // Connect Flags - // User Name Flag(0) - // Password Flag(0) - // Will Retain(0) - // Will QoS(01) - If the Will Flag is set to 0, then the Will QoS MUST be set to 0 - // Will Flag(0) - //Clean Session(1) - .write(0x0A) // Reserved(0) + // Connect Flags + // User Name Flag(0) + // Password Flag(0) + // Will Retain(0) + // Will QoS(01) - If the Will Flag is set to 0, then the Will QoS MUST be set to 0 + // Will Flag(0) + // Clean Session(1) + .write(0x0A) // Reserved(0) - .write(0x00, 0x00) // Keep Alive + .write(0x00, 0x00) // Keep Alive - // Payload - .write(0x00, 0x07) // Client Identifier Length - .write("client1") //Client Identifier + // Payload + .write(0x00, 0x07) // Client Identifier Length + .write("client1") // Client Identifier - //Server MUST close the Network Connection due to invalid Will QoS flag - .closed(); + // Server MUST close the Network Connection due to invalid Will QoS flag + .closed(); } }