diff --git a/broker/src/main/java/org/eclipse/moquette/server/ConfigurationParser.java b/broker/src/main/java/org/eclipse/moquette/server/ConfigurationParser.java index 2844712f..cd556aef 100644 --- a/broker/src/main/java/org/eclipse/moquette/server/ConfigurationParser.java +++ b/broker/src/main/java/org/eclipse/moquette/server/ConfigurationParser.java @@ -15,19 +15,15 @@ */ package org.eclipse.moquette.server; -import java.io.BufferedReader; -import java.io.File; -import java.io.FileNotFoundException; -import java.io.FileReader; -import java.io.IOException; -import java.io.Reader; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.*; import java.text.ParseException; import java.util.Map.Entry; import java.util.Properties; -import org.eclipse.moquette.commons.Constants; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import static org.eclipse.moquette.commons.Constants.*; /** * Mosquitto configuration parser. @@ -58,11 +54,11 @@ class ConfigurationParser { } private void createDefaults() { - m_properties.put(Constants.PORT_PROPERTY_NAME, Integer.toString(Constants.PORT)); - m_properties.put(Constants.HOST_PROPERTY_NAME, Constants.HOST); - m_properties.put(Constants.WEB_SOCKET_PORT_PROPERTY_NAME, Integer.toString(Constants.WEBSOCKET_PORT)); - m_properties.put(Constants.PASSWORD_FILE_PROPERTY_NAME, ""); - m_properties.put(Constants.PERSISTENT_STORE_PROPERTY_NAME, Constants.DEFAULT_PERSISTENT_PATH); + m_properties.put(PORT_PROPERTY_NAME, Integer.toString(PORT)); + m_properties.put(HOST_PROPERTY_NAME, HOST); + m_properties.put(WEB_SOCKET_PORT_PROPERTY_NAME, Integer.toString(WEBSOCKET_PORT)); + m_properties.put(PASSWORD_FILE_PROPERTY_NAME, ""); + m_properties.put(PERSISTENT_STORE_PROPERTY_NAME, DEFAULT_PERSISTENT_PATH); } /** diff --git a/broker/src/main/java/org/eclipse/moquette/server/Server.java b/broker/src/main/java/org/eclipse/moquette/server/Server.java index 606a5c29..e7f78a0a 100644 --- a/broker/src/main/java/org/eclipse/moquette/server/Server.java +++ b/broker/src/main/java/org/eclipse/moquette/server/Server.java @@ -15,16 +15,17 @@ */ package org.eclipse.moquette.server; +import org.eclipse.moquette.server.netty.NettyAcceptor; +import org.eclipse.moquette.spi.impl.SimpleMessaging; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.io.File; import java.io.IOException; import java.text.ParseException; import java.util.Properties; -import org.eclipse.moquette.commons.Constants; -import org.eclipse.moquette.spi.impl.SimpleMessaging; -import org.eclipse.moquette.server.netty.NettyAcceptor; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; /** * Launch a configured version of the server. * @author andrea @@ -87,7 +88,7 @@ public class Server { public void startServer(Properties configProps) throws IOException { ConfigurationParser confParser = new ConfigurationParser(configProps); m_properties = confParser.getProperties(); - LOG.info("Persistent store file: " + m_properties.get(Constants.PERSISTENT_STORE_PROPERTY_NAME)); + LOG.info("Persistent store file: " + m_properties.get(PERSISTENT_STORE_PROPERTY_NAME)); messaging = SimpleMessaging.getInstance(); messaging.init(m_properties); diff --git a/broker/src/main/java/org/eclipse/moquette/spi/impl/SimpleMessaging.java b/broker/src/main/java/org/eclipse/moquette/spi/impl/SimpleMessaging.java index 7a131d78..4cefbd8b 100644 --- a/broker/src/main/java/org/eclipse/moquette/spi/impl/SimpleMessaging.java +++ b/broker/src/main/java/org/eclipse/moquette/spi/impl/SimpleMessaging.java @@ -18,6 +18,21 @@ package org.eclipse.moquette.spi.impl; import com.lmax.disruptor.EventHandler; import com.lmax.disruptor.RingBuffer; import com.lmax.disruptor.dsl.Disruptor; +import org.HdrHistogram.Histogram; +import org.eclipse.moquette.proto.messages.AbstractMessage; +import org.eclipse.moquette.server.IAuthenticator; +import org.eclipse.moquette.server.ServerChannel; +import org.eclipse.moquette.spi.IMessagesStore; +import org.eclipse.moquette.spi.IMessaging; +import org.eclipse.moquette.spi.ISessionsStore; +import org.eclipse.moquette.spi.impl.events.LostConnectionEvent; +import org.eclipse.moquette.spi.impl.events.MessagingEvent; +import org.eclipse.moquette.spi.impl.events.ProtocolEvent; +import org.eclipse.moquette.spi.impl.events.StopEvent; +import org.eclipse.moquette.spi.impl.subscriptions.SubscriptionsStore; +import org.eclipse.moquette.spi.persistence.MapDBPersistentStore; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.util.Properties; import java.util.concurrent.CountDownLatch; @@ -25,18 +40,8 @@ import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; -import org.eclipse.moquette.spi.IMessaging; -import org.eclipse.moquette.spi.ISessionsStore; -import org.eclipse.moquette.spi.IMessagesStore; -import org.eclipse.moquette.spi.impl.events.*; -import org.eclipse.moquette.spi.impl.subscriptions.SubscriptionsStore; -import org.eclipse.moquette.spi.persistence.MapDBPersistentStore; -import org.eclipse.moquette.proto.messages.*; -import org.eclipse.moquette.server.IAuthenticator; -import org.eclipse.moquette.server.ServerChannel; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; -import org.HdrHistogram.Histogram; +import static org.eclipse.moquette.commons.Constants.PASSWORD_FILE_PROPERTY_NAME; +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; /** * @@ -173,7 +178,7 @@ public class SimpleMessaging implements IMessaging, EventHandler { benchmarkEnabled = Boolean.parseBoolean(System.getProperty("moquette.processor.benchmark", "false")); //TODO use a property to select the storage path - MapDBPersistentStore mapStorage = new MapDBPersistentStore(props.getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME, "")); + MapDBPersistentStore mapStorage = new MapDBPersistentStore(props.getProperty(PERSISTENT_STORE_PROPERTY_NAME, "")); m_storageService = mapStorage; m_sessionsStore = mapStorage; @@ -183,7 +188,7 @@ public class SimpleMessaging implements IMessaging, EventHandler { //subscriptions.init(storedSubscriptions); subscriptions.init(m_sessionsStore); - String passwdPath = props.getProperty(org.eclipse.moquette.commons.Constants.PASSWORD_FILE_PROPERTY_NAME, ""); + String passwdPath = props.getProperty(PASSWORD_FILE_PROPERTY_NAME, ""); String configPath = System.getProperty("moquette.path", null); IAuthenticator authenticator; if (passwdPath.isEmpty()) { diff --git a/broker/src/main/java/org/eclipse/moquette/spi/persistence/MapDBPersistentStore.java b/broker/src/main/java/org/eclipse/moquette/spi/persistence/MapDBPersistentStore.java index c0d338fd..06f66b3b 100644 --- a/broker/src/main/java/org/eclipse/moquette/spi/persistence/MapDBPersistentStore.java +++ b/broker/src/main/java/org/eclipse/moquette/spi/persistence/MapDBPersistentStore.java @@ -73,7 +73,7 @@ public class MapDBPersistentStore implements IMessagesStore, ISessionsStore { @Override public void initStore() { - if (m_storePath == null || m_storePath.length() <= 0) { + if (m_storePath == null || m_storePath.isEmpty()) { m_db = DBMaker.newMemoryDB().make(); } else { File tmpFile; diff --git a/broker/src/test/java/org/eclipse/moquette/server/ConfigurationParserTest.java b/broker/src/test/java/org/eclipse/moquette/server/ConfigurationParserTest.java index 1a9758d5..1cc220a2 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ConfigurationParserTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ConfigurationParserTest.java @@ -15,14 +15,17 @@ */ package org.eclipse.moquette.server; +import org.junit.Before; +import org.junit.Test; + import java.io.Reader; import java.io.StringReader; import java.text.ParseException; import java.util.Properties; -import org.eclipse.moquette.commons.Constants; -import org.junit.Test; -import static org.junit.Assert.*; -import org.junit.Before; + +import static org.eclipse.moquette.commons.Constants.HOST; +import static org.eclipse.moquette.commons.Constants.PORT; +import static org.junit.Assert.assertEquals; /** * @@ -98,7 +101,7 @@ public class ConfigurationParserTest { * Helper method to verify default options. */ private void verifyDefaults(Properties props) { - assertEquals(Constants.PORT, Integer.parseInt(props.getProperty("port"))); - assertEquals(Constants.HOST, props.getProperty("host")); + assertEquals(PORT, Integer.parseInt(props.getProperty("port"))); + assertEquals(HOST, props.getProperty("host")); } } \ No newline at end of file diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationFuseTest.java b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationFuseTest.java index 1e578712..ab3723c6 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationFuseTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationFuseTest.java @@ -15,25 +15,21 @@ */ package org.eclipse.moquette.server; +import org.fusesource.mqtt.client.*; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.io.File; import java.io.IOException; import java.util.Properties; import java.util.concurrent.TimeUnit; -import org.fusesource.mqtt.client.BlockingConnection; -import org.fusesource.mqtt.client.MQTT; -import org.fusesource.mqtt.client.Message; -import org.fusesource.mqtt.client.QoS; -import org.fusesource.mqtt.client.Topic; -import org.junit.After; - +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; import static org.junit.Assert.*; -import org.junit.Before; -import org.junit.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - /** * * @author andrea @@ -73,7 +69,7 @@ public class ServerIntegrationFuseTest { } m_server.stopServer(); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationPahoTest.java b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationPahoTest.java index b4f5a877..27e63452 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationPahoTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationPahoTest.java @@ -17,7 +17,10 @@ package org.eclipse.moquette.server; import org.eclipse.paho.client.mqttv3.*; import org.eclipse.paho.client.mqttv3.persist.MqttDefaultFilePersistence; -import org.junit.*; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -25,6 +28,8 @@ import java.io.File; import java.io.IOException; import java.util.Properties; +import static org.eclipse.moquette.commons.Constants.DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME; +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; import static org.junit.Assert.*; public class ServerIntegrationPahoTest { @@ -52,8 +57,8 @@ public class ServerIntegrationPahoTest { @Before public void setUp() throws Exception { - File dbFile = new File(org.eclipse.moquette.commons.Constants.DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME); - assertFalse(String.format("The DB storagefile %s already exists",org.eclipse.moquette.commons.Constants.DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME), dbFile.exists()); + File dbFile = new File(DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME); + assertFalse(String.format("The DB storagefile %s already exists", DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME), dbFile.exists()); startServer(); @@ -69,7 +74,7 @@ public class ServerIntegrationPahoTest { } m_server.stopServer(); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationQoSValidationTest.java b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationQoSValidationTest.java index eee014e9..4f8dad60 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationQoSValidationTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationQoSValidationTest.java @@ -16,25 +16,25 @@ package org.eclipse.moquette.server; -import java.io.File; -import java.io.IOException; -import java.util.Properties; - import org.eclipse.paho.client.mqttv3.IMqttClient; import org.eclipse.paho.client.mqttv3.MqttClient; import org.eclipse.paho.client.mqttv3.MqttClientPersistence; import org.eclipse.paho.client.mqttv3.MqttMessage; import org.eclipse.paho.client.mqttv3.persist.MqttDefaultFilePersistence; import org.junit.After; - -import static org.junit.Assert.assertEquals; - import org.junit.Before; -import org.junit.Test; import org.junit.BeforeClass; +import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import java.io.File; +import java.io.IOException; +import java.util.Properties; + +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; +import static org.junit.Assert.assertEquals; + /** * * @author andrea @@ -89,7 +89,7 @@ public class ServerIntegrationQoSValidationTest { } m_server.stopServer(); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationSSLTest.java b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationSSLTest.java index 1db1c4ad..5dcaca30 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationSSLTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationSSLTest.java @@ -15,40 +15,29 @@ */ package org.eclipse.moquette.server; -import java.io.File; -import java.io.IOException; -import java.io.InputStream; -import java.security.KeyManagementException; -import java.security.KeyStore; -import java.security.KeyStoreException; -import java.security.NoSuchAlgorithmException; -import java.security.UnrecoverableKeyException; -import java.security.cert.CertificateException; -import java.util.Properties; - -import javax.net.ssl.KeyManagerFactory; -import javax.net.ssl.SSLContext; -import javax.net.ssl.SSLSocketFactory; -import javax.net.ssl.TrustManager; -import javax.net.ssl.TrustManagerFactory; - -import org.eclipse.moquette.commons.*; -import org.eclipse.moquette.commons.Constants; import org.eclipse.paho.client.mqttv3.IMqttClient; import org.eclipse.paho.client.mqttv3.MqttClient; import org.eclipse.paho.client.mqttv3.MqttClientPersistence; import org.eclipse.paho.client.mqttv3.MqttConnectOptions; import org.eclipse.paho.client.mqttv3.persist.MqttDefaultFilePersistence; import org.junit.After; - -import static org.junit.Assert.assertFalse; - import org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import javax.net.ssl.*; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.security.*; +import java.security.cert.CertificateException; +import java.util.Properties; + +import static org.eclipse.moquette.commons.Constants.*; +import static org.junit.Assert.assertFalse; + /** * Check that Moquette could also handle SSL. * @@ -75,17 +64,17 @@ public class ServerIntegrationSSLTest { m_server = new Server(); Properties sslProps = new Properties(); - sslProps.put(org.eclipse.moquette.commons.Constants.SSL_PORT_PROPERTY_NAME, "8883"); - sslProps.put(org.eclipse.moquette.commons.Constants.JKS_PATH_PROPERTY_NAME, "serverkeystore.jks"); - sslProps.put(org.eclipse.moquette.commons.Constants.KEY_STORE_PASSWORD_PROPERTY_NAME, "passw0rdsrv"); - sslProps.put(Constants.KEY_MANAGER_PASSWORD_PROPERTY_NAME, "passw0rdsrv"); + sslProps.put(SSL_PORT_PROPERTY_NAME, "8883"); + sslProps.put(JKS_PATH_PROPERTY_NAME, "serverkeystore.jks"); + sslProps.put(KEY_STORE_PASSWORD_PROPERTY_NAME, "passw0rdsrv"); + sslProps.put(KEY_MANAGER_PASSWORD_PROPERTY_NAME, "passw0rdsrv"); m_server.startServer(sslProps); } @Before public void setUp() throws Exception { - File dbFile = new File(org.eclipse.moquette.commons.Constants.DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME); - assertFalse(String.format("The DB storage file %s already exists",org.eclipse.moquette.commons.Constants.DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME), dbFile.exists()); + File dbFile = new File(DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME); + assertFalse(String.format("The DB storage file %s already exists", DEFAULT_MOQUETTE_STORE_MAP_DB_FILENAME), dbFile.exists()); startServer(); diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationWebSocketTest.java b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationWebSocketTest.java index 314acd83..fc91fdc6 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationWebSocketTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerIntegrationWebSocketTest.java @@ -15,29 +15,29 @@ */ package org.eclipse.moquette.server; +import org.eclipse.jetty.websocket.client.ClientUpgradeRequest; +import org.eclipse.jetty.websocket.client.WebSocketClient; +import org.eclipse.moquette.commons.Constants; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.io.File; import java.io.IOException; import java.net.URI; import java.util.Properties; import java.util.concurrent.TimeUnit; -import org.eclipse.jetty.websocket.client.WebSocketClient; -import org.eclipse.jetty.websocket.client.ClientUpgradeRequest; -import org.eclipse.moquette.commons.Constants; -import org.junit.After; - +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; import static org.junit.Assert.assertTrue; -import org.junit.Before; -import org.junit.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - /** * Integration test to check the function of Moquette with a WebSocket channel. * - * @author andrea + * @author andreaorg.eclipse.moquette.commons.Constants. */ public class ServerIntegrationWebSocketTest { private static final Logger LOG = LoggerFactory.getLogger(ServerIntegrationPahoTest.class); @@ -61,7 +61,7 @@ public class ServerIntegrationWebSocketTest { client.stop(); m_server.stopServer(); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerLowlevelMessagesIntegrationTests.java b/broker/src/test/java/org/eclipse/moquette/server/ServerLowlevelMessagesIntegrationTests.java index 64c1703d..7f677edd 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerLowlevelMessagesIntegrationTests.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerLowlevelMessagesIntegrationTests.java @@ -15,31 +15,27 @@ */ package org.eclipse.moquette.server; +import org.eclipse.moquette.proto.messages.AbstractMessage; +import org.eclipse.moquette.proto.messages.AbstractMessage.QOSType; +import org.eclipse.moquette.proto.messages.ConnAckMessage; +import org.eclipse.moquette.proto.messages.ConnectMessage; +import org.eclipse.moquette.testclient.Client; +import org.fusesource.mqtt.client.*; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.io.File; import java.io.IOException; import java.util.Properties; import java.util.concurrent.CountDownLatch; import java.util.concurrent.TimeUnit; -import org.eclipse.moquette.proto.messages.AbstractMessage; -import org.eclipse.moquette.proto.messages.AbstractMessage.QOSType; -import org.eclipse.moquette.proto.messages.ConnAckMessage; -import org.eclipse.moquette.proto.messages.ConnectMessage; -import org.eclipse.moquette.testclient.Client; -import org.fusesource.mqtt.client.BlockingConnection; -import org.fusesource.mqtt.client.MQTT; -import org.fusesource.mqtt.client.Message; -import org.fusesource.mqtt.client.QoS; -import org.fusesource.mqtt.client.Topic; -import org.junit.After; - +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; import static org.junit.Assert.*; -import org.junit.Before; -import org.junit.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - /** * * @author andrea @@ -72,7 +68,7 @@ public class ServerLowlevelMessagesIntegrationTests { Thread.sleep(300); //to let the close event pass before server stop event m_server.stopServer(); LOG.debug("After asked server to stop"); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } diff --git a/broker/src/test/java/org/eclipse/moquette/server/ServerRestartIntegrationTest.java b/broker/src/test/java/org/eclipse/moquette/server/ServerRestartIntegrationTest.java index 13053de2..113f5041 100644 --- a/broker/src/test/java/org/eclipse/moquette/server/ServerRestartIntegrationTest.java +++ b/broker/src/test/java/org/eclipse/moquette/server/ServerRestartIntegrationTest.java @@ -15,21 +15,19 @@ */ package org.eclipse.moquette.server; +import org.fusesource.mqtt.client.*; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + import java.io.File; import java.io.IOException; import java.util.Properties; import java.util.concurrent.TimeUnit; -import org.fusesource.mqtt.client.BlockingConnection; -import org.fusesource.mqtt.client.MQTT; -import org.fusesource.mqtt.client.Message; -import org.fusesource.mqtt.client.QoS; -import org.fusesource.mqtt.client.Topic; -import org.junit.After; -import org.junit.Before; -import org.junit.Test; - -import static org.junit.Assert.*; +import static org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; /** * @@ -68,7 +66,7 @@ public class ServerRestartIntegrationTest { } m_server.stopServer(); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } @@ -87,7 +85,7 @@ public class ServerRestartIntegrationTest { //shutdown the server m_server.stopServer(); - File dbFile = new File(m_server.getProperties().getProperty(org.eclipse.moquette.commons.Constants.PERSISTENT_STORE_PROPERTY_NAME)); + File dbFile = new File(m_server.getProperties().getProperty(PERSISTENT_STORE_PROPERTY_NAME)); if (dbFile.exists()) { dbFile.delete(); } diff --git a/broker/src/test/java/org/eclipse/moquette/spi/impl/MapDBPersistentStoreTest.java b/broker/src/test/java/org/eclipse/moquette/spi/impl/MapDBPersistentStoreTest.java index e20b5bda..3852a856 100644 --- a/broker/src/test/java/org/eclipse/moquette/spi/impl/MapDBPersistentStoreTest.java +++ b/broker/src/test/java/org/eclipse/moquette/spi/impl/MapDBPersistentStoreTest.java @@ -15,19 +15,19 @@ */ package org.eclipse.moquette.spi.impl; +import org.eclipse.moquette.proto.messages.AbstractMessage; +import org.eclipse.moquette.spi.impl.subscriptions.Subscription; +import org.eclipse.moquette.spi.persistence.MapDBPersistentStore; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + import java.io.File; import java.util.List; -import org.eclipse.moquette.spi.impl.subscriptions.Subscription; -import org.eclipse.moquette.spi.persistence.MapDBPersistentStore; -import org.eclipse.moquette.proto.messages.AbstractMessage; -import org.junit.After; -import org.junit.Test; - +import static org.eclipse.moquette.commons.Constants.DEFAULT_PERSISTENT_PATH; import static org.junit.Assert.*; -import org.junit.Before; - /** * * @author andrea @@ -39,10 +39,10 @@ public class MapDBPersistentStoreTest { @Before public void setUp() throws Exception { - File dbFile = new File(org.eclipse.moquette.commons.Constants.DEFAULT_PERSISTENT_PATH); - assertFalse(String.format("The DB storagefile %s already exists", org.eclipse.moquette.commons.Constants.DEFAULT_PERSISTENT_PATH), dbFile.exists()); + File dbFile = new File(DEFAULT_PERSISTENT_PATH); + assertFalse(String.format("The DB storagefile %s already exists", DEFAULT_PERSISTENT_PATH), dbFile.exists()); - m_storageService = new MapDBPersistentStore(org.eclipse.moquette.commons.Constants.DEFAULT_PERSISTENT_PATH); + m_storageService = new MapDBPersistentStore(DEFAULT_PERSISTENT_PATH); m_storageService.initStore(); } @@ -52,9 +52,9 @@ public class MapDBPersistentStoreTest { m_storageService.close(); } - File dbFile = new File(org.eclipse.moquette.commons.Constants.DEFAULT_PERSISTENT_PATH); + File dbFile = new File(DEFAULT_PERSISTENT_PATH); if (dbFile.exists()) { - assertTrue("Error deleting the moquette db file " + org.eclipse.moquette.commons.Constants.DEFAULT_PERSISTENT_PATH, dbFile.delete()); + assertTrue("Error deleting the moquette db file " + DEFAULT_PERSISTENT_PATH, dbFile.delete()); } assertFalse(dbFile.exists()); }