diff --git a/broker/src/test/java/io/moquette/spi/persistence/MapDBPersistentStoreTest.java b/broker/src/test/java/io/moquette/spi/persistence/MapDBPersistentStoreTest.java index 268b135b..9f0f4a92 100644 --- a/broker/src/test/java/io/moquette/spi/persistence/MapDBPersistentStoreTest.java +++ b/broker/src/test/java/io/moquette/spi/persistence/MapDBPersistentStoreTest.java @@ -13,6 +13,7 @@ * * You may elect to redistribute this code under either of these licenses. */ + package io.moquette.spi.persistence; import io.moquette.BrokerConstants; @@ -29,11 +30,9 @@ import io.netty.handler.codec.mqtt.MqttQoS; import org.junit.After; import org.junit.Before; import org.junit.Test; - import java.util.List; import java.util.Properties; import java.util.concurrent.TimeUnit; - import static org.junit.Assert.*; /** @@ -80,7 +79,7 @@ public class MapDBPersistentStoreTest { Subscription overridingSubscription = new Subscription(session1.clientID, "/topic", MqttQoS.EXACTLY_ONCE); session1.subscribe(overridingSubscription); - //Verify + // Verify List subscriptions = m_sessionsStore.listAllSubscriptions(); assertEquals(1, subscriptions.size()); Subscription sub = m_sessionsStore.getSubscription(subscriptions.get(0)); @@ -95,27 +94,28 @@ public class MapDBPersistentStoreTest { @Test public void testNextPacketID_existingClientSession() { - //Force creation of inflight map for the CLIENT session + // Force creation of inflight map for the CLIENT session int packetId = m_sessionsStore.nextPacketID("CLIENT"); assertEquals(1, packetId); - //request a second packetID + // request a second packetID packetId = m_sessionsStore.nextPacketID("CLIENT"); assertEquals(2, packetId); } @Test public void testNextPacketID() { - //request a first ID + // request a first ID int packetId = m_sessionsStore.nextPacketID("CLIENT"); - m_sessionsStore.inFlight("CLIENT", packetId, new MessageGUID("ABCDE")); //simulate an inflight + m_sessionsStore.inFlight("CLIENT", packetId, new MessageGUID("ABCDE")); // simulate an + // inflight assertEquals(1, packetId); - //release the ID + // release the ID m_sessionsStore.inFlightAck("CLIENT", packetId); - //request a second packetID, counter restarts from 0 + // request a second packetID, counter restarts from 0 packetId = m_sessionsStore.nextPacketID("CLIENT"); assertEquals(1, packetId); } @@ -124,8 +124,9 @@ public class MapDBPersistentStoreTest { public void testCloseShutdownCommitTask() throws InterruptedException { m_storageService.close(); - //verify the executor is shutdown - assertTrue("Storage service scheduler can't be stopped in 3 seconds", + // verify the executor is shutdown + assertTrue( + "Storage service scheduler can't be stopped in 3 seconds", m_storageService.m_scheduler.awaitTermination(3, TimeUnit.SECONDS)); assertTrue(m_storageService.m_scheduler.isTerminated()); } @@ -133,17 +134,19 @@ public class MapDBPersistentStoreTest { @Test public void testDropMessagesInSessionCleanAllNotRetainedStoredMessages() { m_sessionsStore.createNewSession("TestClient", true); - IMessagesStore.StoredMessage publishToStore = new IMessagesStore.StoredMessage("Hello".getBytes(), - MqttQoS.EXACTLY_ONCE, "/topic"); + IMessagesStore.StoredMessage publishToStore = new IMessagesStore.StoredMessage( + "Hello".getBytes(), + MqttQoS.EXACTLY_ONCE, + "/topic"); publishToStore.setClientID(TEST_CLIENT); publishToStore.setMessageID(1); publishToStore.setRetained(false); MessageGUID guid = m_messagesStore.storePublishForFuture(publishToStore); - //Exercise + // Exercise m_messagesStore.dropMessagesInSession("TestClient"); - //Verify the message store for session is empty. + // Verify the message store for session is empty. IMessagesStore.StoredMessage storedPublish = m_messagesStore.getMessageByGuid(guid); assertNull("The stored message must'n be present anymore", storedPublish); } @@ -151,18 +154,20 @@ public class MapDBPersistentStoreTest { @Test public void testDropMessagesInSessionDoesntCleanAnyRetainedStoredMessages() { m_sessionsStore.createNewSession("TestClient", true); - IMessagesStore.StoredMessage publishToStore = new IMessagesStore.StoredMessage("Hello".getBytes(), - MqttQoS.EXACTLY_ONCE, "/topic"); + IMessagesStore.StoredMessage publishToStore = new IMessagesStore.StoredMessage( + "Hello".getBytes(), + MqttQoS.EXACTLY_ONCE, + "/topic"); publishToStore.setClientID(TEST_CLIENT); publishToStore.setMessageID(1); publishToStore.setRetained(true); MessageGUID guid = m_messagesStore.storePublishForFuture(publishToStore); - //Exercise + // Exercise m_messagesStore.dropMessagesInSession("TestClient"); - //Verify the message store for session is empty. + // Verify the message store for session is empty. IMessagesStore.StoredMessage storedPublish = m_messagesStore.getMessageByGuid(guid); assertNotNull("The stored retained message must be present after client's session drop", storedPublish); } -} \ No newline at end of file +}