Modified the format of password_file.conf now accept only sha256 hashed passwords

broker/config/password_file.conf

@@ -1 +1,2 @@
-testuser:passwd
+#the password is sha256(passwd)
+testuser:36767030e79073783c8e9b299d9f8f1d4cd66baa82cd8869caad8dbb55204099

broker/pom.xml

@@ -106,6 +106,12 @@
             <artifactId>netty-codec-http</artifactId>
             <version>${netty.version}</version>
         </dependency>
+
+        <dependency>
+            <groupId>commons-codec</groupId>
+            <artifactId>commons-codec</artifactId>
+            <version>1.10</version>
+        </dependency>
         
         <dependency>
             <groupId>org.mapdb</groupId>

broker/src/main/java/org/eclipse/moquette/spi/impl/FileAuthenticator.java

@@ -15,20 +15,27 @@
  */
 package org.eclipse.moquette.spi.impl;
 
-import java.io.BufferedReader;
+import org.apache.commons.codec.binary.Hex;
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.FileReader;
-import java.io.IOException;
-import java.io.Reader;
-import java.text.ParseException;
-import java.util.HashMap;
-import java.util.Map;
 import org.eclipse.moquette.server.IAuthenticator;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.io.*;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+import java.text.ParseException;
+import java.util.HashMap;
+import java.util.Map;
+
 /**
+ * Load user credentials from a text file.
+ * Each line of the file is formatted as "<username>:<sha256(password)>". The username mustn't contains : char.
+ *
+ * To encode your password from command line on Linux systems, you could use:
+ * <pre>
+ *     echo -n "yourpassword" | sha256sum
+ * </pre>
+ * NB -n is important because echo append a newline by default at the of string. -n avoid this behaviour.
  *
  * @author andrea
  */
@@ -36,8 +43,9 @@ public class FileAuthenticator implements IAuthenticator {
 
     private static final Logger LOG = LoggerFactory.getLogger(FileAuthenticator.class);
     
-    private Map<String, String> m_identities = new HashMap<String, String>();
+    private Map<String, String> m_identities = new HashMap<>();
-    
+    private MessageDigest m_digest;
+
     FileAuthenticator(String parent, String filePath) {
         File file = new File(parent, filePath);
         LOG.info("Loading password file: " + file);
@@ -45,14 +53,20 @@ public class FileAuthenticator implements IAuthenticator {
             LOG.warn(String.format("Bad file reference %s is a directory", file));
             return;
         }
-            
+        try {
+            this.m_digest = MessageDigest.getInstance("SHA-256");
+        } catch (NoSuchAlgorithmException nsaex) {
+            LOG.error("Can't find SHA-256 for password encoding", nsaex);
+            throw new RuntimeException(nsaex);
+        }
+
         try {
             FileReader reader = new FileReader(file);
             parse(reader);
         } catch (FileNotFoundException fex) {
             LOG.warn(String.format("Parsing not existing file %s", file), fex);
         } catch (ParseException pex) {
-            LOG.warn(String.format("Fromat ero in parsing password file %s", file), pex);
+            LOG.warn(String.format("Format error in parsing password file %s", file), pex);
         }
     }
     
@@ -81,9 +95,9 @@ public class FileAuthenticator implements IAuthenticator {
                     }
                     
                     //split till the first space
-                    int deilimiterIdx = line.indexOf(':');
+                    int delimiterIdx = line.indexOf(':');
-                    String username = line.substring(0, deilimiterIdx).trim();
+                    String username = line.substring(0, delimiterIdx).trim();
-                    String password = line.substring(deilimiterIdx + 1).trim();
+                    String password = line.substring(delimiterIdx + 1).trim();
                     
                     m_identities.put(username, password);
                 }
@@ -98,8 +112,14 @@ public class FileAuthenticator implements IAuthenticator {
         if (foundPwq == null) {
             return false;
         }
-        
+        try {
-        return foundPwq.equals(password);
+            m_digest.update(password.getBytes("UTF-8"));
+        } catch (UnsupportedEncodingException e) {
+            e.printStackTrace();
+        }
+        byte[] digest = m_digest.digest();
+        String encodedPasswd = new String(Hex.encodeHex(digest));
+        return foundPwq.equals(encodedPasswd);
     }
     
 }

broker/src/test/java/org/eclipse/moquette/spi/impl/FileAuthenticatorTest.java

@@ -17,7 +17,9 @@ package org.eclipse.moquette.spi.impl;
 
 import org.eclipse.moquette.server.IAuthenticator;
 import org.junit.Test;
-import static org.junit.Assert.*;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 /**
  *
@@ -47,5 +49,5 @@ public class FileAuthenticatorTest {
         
         assertFalse(auth.checkValid("testuser2", "passwd"));
     }
-    
+
 }

broker/src/test/resources/config/password_file.conf

@@ -1 +1,2 @@
-testuser:passwd
+#the password is sha256(passwd)
+testuser:0d6be69b264717f2dd33652e212b173104b4a647b7c11ae72e9885f11cd312fb

broker/src/test/resources/password_file.conf

@@ -1 +1,2 @@
-testuser:passwd
+#the password is sha256(passwd)
+testuser:0d6be69b264717f2dd33652e212b173104b4a647b7c11ae72e9885f11cd312fb