Minor, fixed checkstyle and find bugs warns

2018-11-10 18:31:51 +01:00
parent 9ceb26307e
commit 284417ef50
34 changed files with 407 additions and 73 deletions
@@ -29,11 +29,18 @@ public abstract class IConfig {

    /**
     * Same semantic of Properties
+     *
+     * @param name property name.
+     * @return property value.
     * */
    public abstract String getProperty(String name);

    /**
     * Same semantic of Properties
+     *
+     * @param name property name.
+     * @param defaultValue default value to return in case the property doesn't exists.
+     * @return property value.
     * */
    public abstract String getProperty(String name, String defaultValue);

@@ -111,7 +111,8 @@ public class AutoFlushHandler extends ChannelDuplexHandler {
        // Avoid the case where destroy() is called before scheduling timeouts.
        // See: https://github.com/netty/netty/issues/143
        if (LOG.isDebugEnabled()) {
-            LOG.debug("Initializing autoflush handler on channel {} Cid: {}", ctx.channel(), NettyUtils.clientID(ctx.channel()));
+            LOG.debug("Initializing autoflush handler on channel {} Cid: {}", ctx.channel(),
+                      NettyUtils.clientID(ctx.channel()));
        }
        switch (state) {
            case 1:
@@ -60,7 +60,7 @@ public class MQTTMessageLogger extends ChannelDuplexHandler {
        }
        MqttMessage msg = (MqttMessage) message;
        if (msg.fixedHeader() == null) {
-        	throw new IOException("Unknown packet");
+            throw new IOException("Unknown packet");
        }
        String clientID = NettyUtils.clientID(ctx.channel());
        MqttMessageType messageType = msg.fixedHeader().messageType();
@@ -69,7 +69,7 @@ public class MQTTMessageLogger extends ChannelDuplexHandler {
            case PINGREQ:
            case PINGRESP:
                LOG.debug("{} {} <{}>", direction, messageType, clientID);
-                break;        
+                break;
            case CONNECT:
            case DISCONNECT:
                LOG.info("{} {} <{}>", direction, messageType, clientID);